Closed Subtletree closed 6 years ago
looks good -- my only concern is that existing tests were modified. why the config additions?
Previously when podModulePrefix
= ''
, config files weren't being migrated correctly but there was no tests to catch it.
'config': {
'foo': {
'baz.sh': 'yolo'
}
},
was being transformed into:
{
config: {
+ baz.sh: "yolo"
foo: {
- baz.sh: "yolo"
}
}
}
if (!arePodsNamespaced) {
...
if (type === undefined){
// was getting modified here
}
}
oh ok. cool :+1:
Thank you!
When no
podModulePrefix
is specified in environment.js thenpodModulePrefix
isundefined
rather than'pods'
or''
.podModulePrefix = undefined