search

ember-codemods / ember-native-class-codemod

A codemod-cli project for converting Ember objects to es6 native classes
67 stars 38 forks source link

Puppeteer version is not compatible with M1 Macs #480

Open kevinansfield opened 2 years ago

kevinansfield commented 2 years ago

On M1 Macs puppeteer does not correctly load Chrome/Chromium with the error:

/Users/kevin/.npm/_npx/4e4aff0f1510c9e0/node_modules/ember-codemods-telemetry-helpers/node_modules/puppeteer/lib/cjs/puppeteer/node/BrowserRunner.js:193
            reject(new Error([
                   ^

Error: Failed to launch the browser process! spawn /usr/bin/chromium-browser ENOENT

This was an issue in Puppeteer that has been fixed 10.0.0 and later - https://github.com/puppeteer/puppeteer/issues/6622. With the version used in this package there's no way to override the Chrome location that puppeteer will use because the path was hardcoded.

There's an open pull request to bump the puppeteer version here: https://github.com/ember-codemods/ember-native-class-codemod/pull/468

dgeb commented 1 year ago

I believe this issue has been resolved in v3.0.0.