search

ember-codemods / ember-native-class-codemod

A codemod-cli project for converting Ember objects to es6 native classes
67 stars 38 forks source link

update to the latest puppeteer #486

Closed mansona closed 2 years ago

mansona commented 2 years ago

You need at least puppeteer@15.3.2 to be able to run this codemod on an M1 Mac

https://github.com/puppeteer/puppeteer/commit/9a8479a52a7d8b51690b0732b2a10816cd1b8aef

mansona commented 2 years ago

So it turns out that the latest puppeteer only supports non EOL Node versions (I know right! 🙄) so we should possibly consider doing the same. I opened a PR to do that https://github.com/ember-codemods/ember-native-class-codemod/pull/490

pmusaraj commented 2 years ago

@mansona does this need a new version bumped and published to NPM for people like myself to be able to use it when doing npx ember-native-class-codemod ...? Because when I currently run the command on an M1 machine, I still get a puppeteer error and the package points to the version published in NPM ~1 year ago.

mansona commented 2 years ago

Yes exactly, I'm in the process of getting npm publish rights for this to solve that problem for you 👍