search

ember-codemods / ember-native-class-codemod

A codemod-cli project for converting Ember objects to es6 native classes
67 stars 38 forks source link

Produces class decorator usage with incorrect syntax #495

Open runspired opened 1 year ago

runspired commented 1 year ago

bad:

@classic
export default class TestComponent extends Component {
  @fullNameMacro()
  fullName;
}

good:

@classic
class TestComponent extends Component {
  @fullNameMacro()
  fullName;
}

export default TestComponent;

see https://github.com/ember-cli/eslint-plugin-ember/issues/1699 for additional context

gitKrystan commented 1 year ago

Update:

@classic export default TestComponent extends Component {} is legal now.

https://twitter.com/leobalter/status/1621242353494425602

https://github.com/tc39/notes/blob/c7fa95d3f2d0af68eaba9d388d5f79f2e166a4cc/meetings/2023-01/feb-02.md#conclusionresolution-4