ember-codemods / ember-native-class-codemod

A codemod-cli project for converting Ember objects to es6 native classes
68 stars 38 forks source link

Upgrade Dependencies + Fix CI #529

Closed gitKrystan closed 1 year ago

gitKrystan commented 1 year ago

Upgrade dependencies. During the upgrades, I noticed that tests were failing for Node 16+ because of https://github.com/ember-cli/ember-cli/pull/9987. The fixture app was using super old ember-cli which is not Node 16 compatible. Upgrading to 3.28 resolves this.

Notably, CI wasn't failing even though the tests were failing, so this PR also resolves that issue.