search

ember-codemods / ember-no-implicit-this-codemod

Template codemod for refactoring from `{{foo}}` to `{{this.foo}}`
MIT License
17 stars 25 forks source link

Use puppeteer resolution to support M1 Macs. #398

Closed deanmarano closed 8 months ago

deanmarano commented 1 year ago

This package uses ember-codemod-telemetry-helpers, which in turn uses puppeteer to launch a browser. Upgrading this package to 3.0 resulted in node versions needing to be updated in the build, so to continue the current node setup, I used a resolution to pin puppeteer to a compatible version.

deanmarano commented 1 year ago

Any chance on getting this merged?

LucasHillDex commented 11 months ago

Yes let's get this working! I imagine upgrading ember-codemod-telemetry-helpers is the better option over using forced resolutions though.

rwolffgang commented 10 months ago

Thank you very much for the fix, it saved me a lot of time! @deanmarano

mansona commented 8 months ago

This has been fixed in https://github.com/ember-codemods/ember-no-implicit-this-codemod/pull/400