search

ember-codemods / ember-qunit-codemod

MIT License
36 stars 20 forks source link

Fails with node 8 #116

Open vladucu opened 6 years ago

vladucu commented 6 years ago

Hey @rwjblue , thx for this

Just wanted to report that I've run into some issues running it with node 8.11.1, but seems to be working fine with 6

screen shot 2018-06-28 at 3 09 54 pm
rwjblue commented 6 years ago

Seems really odd. I run tests (for codemod-cli) on Node 6, 8, and 10 (and they are all passing).

Can you confirm that the path specified matched a file (from the screenshot)?

vladucu commented 6 years ago

yes, same command

screen shot 2018-06-28 at 8 30 01 pm

if there's anything I can help with to track this down, let me know pls

kybishop commented 6 years ago

Running into this as well. In my case I can't get it to work with any node version but see the same error.

kybishop commented 6 years ago

I finally found a workaround: install ember-qunit-codemod as a dev-dependency, then run it locally:

npx ./node_modules/ember-qunit-codemod/bin/cli.js convert-module-for-to-setup-test tests/integration/**/*.js

I'm not sure what's happening that's corrupting the global installation, but this worked just fine on any node version.

mike-north commented 6 years ago

@rwjblue I have a repro case on my work machine. If you want to look at it sometime, happy to let you remote in