search

ember-codemods / es5-getter-ember-codemod

34 stars 14 forks source link

Not sure if this codemod works properly #26

Closed olenderhub closed 5 years ago

olenderhub commented 5 years ago

After I run ember-cli-update --run-codemods and then es5-getter-ember-codemod I noticed not all "get" were removed, for example still I have: get(this, 'store'); or get(this, 'ajax') and many other cases. Is it a problem with this codemod or for some purposes codemod skip it?

my result is:

Results:
0 errors
319 unmodified
0 skipped
0 ok
olenderhub commented 5 years ago

As I talked with @Turbo87 on Discord:

@Turbo87 said:

the codemod is trying to play if safe, which is why it's not converting all of them

@Turbo87 suggestion:

I'd suggest to just do a simple find-and-replace on the most common services that you use
at least that's what I did on most apps that I've updated

I am closing this issue.