search

ember-components / ember-component-patterns

Transforming https://emberjs-1.gitbook.io/ember-component-patterns/ into an Ember app
7 stars 2 forks source link

Add linkable header component #13

Closed hergaiety closed 3 years ago

hergaiety commented 3 years ago

Screenshot_2020-12-09_08-27-25

Like the previous site (https://emberjs-1.gitbook.io/ember-component-patterns/) users should be able to focus on or hover over a header to see a link icon. Clicking it should navigate to an anchor link tied to the same headline.

This will be a very common thing throughout the app so we may wish to make a simple component for this.

mattfrankjames commented 3 years ago

I have submitted a PR for this.

hergaiety commented 3 years ago

Thanks @mattfrankjames for knocking this out! https://github.com/ember-components/ember-component-patterns/pull/15 Tiny FYI, in the future these issues can be autoclosed by including resolves #13 for example in the PR description. I'll happily close this manually, cheers~!