ember-components / ember-component-patterns

Transforming https://emberjs-1.gitbook.io/ember-component-patterns/ into an Ember app
7 stars 2 forks source link

Fix sidenav click elsewhere issue, loc, desktop visibility #60

Closed hergaiety closed 3 years ago

hergaiety commented 3 years ago

Fixes a number of issues found after merging in the side nav.

  1. Fixes a race condition creating and removing click handlers in the click-elsewhere modifier that resulted in the menu appearing to not open after changing browser size between mobile/desktop sizes
  2. Fixed missed localization aria labels
  3. Fixed visibility of side navigation on desktop