search

ember-decorators / argument

Decorators for Component and Object arguments in Ember
MIT License
30 stars 18 forks source link

refactor: revert to legacy decorators #109

Open buschtoens opened 5 years ago

buschtoens commented 5 years ago

This reverts this addon to use stage 1 / legacy decorators again and also upgrades a bunch of dependencies.

buschtoens commented 5 years ago

Compatibility notes in README need to be updated.

Let me know, if you feel that patch-method + ember-auto-import is to heavyweight and we should just monkey patch init in place.

buschtoens commented 5 years ago

105 also still remains, I guess.

alexlafroscia commented 5 years ago

It looks like on beta and canary, rather than "resolving" a computed property and getting the actual value, it instead is seeing the type to check against as ComputedProperty

Any idea why that behavior would have changed in the next beta/canary version of Ember?

miguelcobain commented 5 years ago

@buschtoens @alexlafroscia do you think this will be happening anytime soon?

I'm considering dropping @ember-decorators/argument in my ember-yeti-table addon to make it compatible with latest ember and native ember decorators.

It would be nice to get some updates. Thank you!

alexlafroscia commented 5 years ago

I could take a look at why the PR isn't working, but @buschtoens probably has more context on why things aren't working.

Honestly, I would probably just remove @argument until the decorators stuff has fully resolved. Even having done a lot of the work on this add-on, it's mostly just been a pain point for me! I'm not sure the runtime validation is worth the developer overhead.

cah-brian-gantzler commented 5 years ago

While working on a PR for yeti-table that was eventually merged, the @argument actually caught a few bugs of mine and saved me time. I found it very useful

miguelcobain commented 5 years ago

I wonder if migrating to Typescript is a 1:1 equivalence?

jelhan commented 5 years ago

This might fix #111.

theseyi commented 4 years ago

Is this still in progress? Sorry, I know I'm asking before the holidays

buschtoens commented 4 years ago

I'm not working on it, sorry. I'm not actively using this addon, as it does not work with Glimmer components.

alexlafroscia commented 4 years ago

I’m not working on it either, unfortunately.

I wouldn’t introduce this into a new codebase since it goes against the direction Glimmer is taking.

What is interesting to me is some means for annotating defaults for arguments in a Glimmer component, but that would be a totally separate project than this.

On Nov 28, 2019, at 3:49 AM, Jan Buschtöns notifications@github.com wrote:

 I'm not working on it, sorry. I'm not actively using this addon, as it does not work with Glimmer components.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

theseyi commented 4 years ago

Thanks for the quick update guys. I guess this version could probably be marked deprecated so users don’t go through the trouble of trying to include it and then finding out it’s incompatible with the current decorators implementation and /or glimmer components

From: Alex LaFroscia notifications@github.com Sent: Thursday, November 28, 2019 9:26:50 AM To: ember-decorators/argument argument@noreply.github.com Cc: Seyi Adebajo seyi@outlook.com; Comment comment@noreply.github.com Subject: Re: [ember-decorators/argument] refactor: revert to legacy decorators (#109)

I’m not working on it either, unfortunately.

I wouldn’t introduce this into a new codebase since it goes against the direction Glimmer is taking.

What is interesting to me is some means for annotating defaults for arguments in a Glimmer component, but that would be a totally separate project than this.

On Nov 28, 2019, at 3:49 AM, Jan Buschtöns notifications@github.com wrote:

 I'm not working on it, sorry. I'm not actively using this addon, as it does not work with Glimmer components.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/ember-decorators/argument/pull/109?email_source=notifications&email_token=AA4NT7LDJNJODZ47RSNFMQ3QV75NVA5CNFSM4HIRAAH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNFHTI#issuecomment-559567821, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA4NT7KJ2UZVORQEIDMAX3TQV75NVANCNFSM4HIRAAHQ.

alexlafroscia commented 4 years ago

That is a good idea!

On Nov 28, 2019, at 5:50 PM, Seyi Adebajo notifications@github.com wrote:

Thanks for the quick update guys. I guess this version could probably be marked deprecated so users don’t go through the trouble of trying to include it and then finding out it’s incompatible with the current decorators implementation and /or glimmer components

From: Alex LaFroscia notifications@github.com Sent: Thursday, November 28, 2019 9:26:50 AM To: ember-decorators/argument argument@noreply.github.com Cc: Seyi Adebajo seyi@outlook.com; Comment comment@noreply.github.com Subject: Re: [ember-decorators/argument] refactor: revert to legacy decorators (#109)

I’m not working on it either, unfortunately.

I wouldn’t introduce this into a new codebase since it goes against the direction Glimmer is taking.

What is interesting to me is some means for annotating defaults for arguments in a Glimmer component, but that would be a totally separate project than this.

On Nov 28, 2019, at 3:49 AM, Jan Buschtöns notifications@github.com wrote:

 I'm not working on it, sorry. I'm not actively using this addon, as it does not work with Glimmer components.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/ember-decorators/argument/pull/109?email_source=notifications&email_token=AA4NT7LDJNJODZ47RSNFMQ3QV75NVA5CNFSM4HIRAAH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNFHTI#issuecomment-559567821, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA4NT7KJ2UZVORQEIDMAX3TQV75NVANCNFSM4HIRAAHQ. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.