ember-decorators / argument

Decorators for Component and Object arguments in Ember
MIT License
30 stars 18 forks source link

Upgrade to Babel 7 #80

Closed alexlafroscia closed 5 years ago

alexlafroscia commented 6 years ago

As talked about in #75, this drops Babel 6 support entirely in favor of Babel 7

alexlafroscia commented 6 years ago

I've been digging into this issue all morning and haven't made any headway yet. Partly for my own sake, I'll leave some notes:

alexlafroscia commented 6 years ago

Aha! babel-plugin-filter-imports is the culprit

https://github.com/ember-cli/babel-plugin-filter-imports/blob/f2b57e1a7a26091be5389745ea085aef6d3c4869/src/index.js#L9

@pzuraq you added the original inclusion of the decorators plugin to that -- why does the import filter care about decorators?

https://github.com/ember-cli/babel-plugin-filter-imports/commit/69fd4359d41240469e2cb7062d3dc3cd860de948

alexlafroscia commented 6 years ago

I opened this PR on babel-plugin-filter-imports in hopes of moving this along.

https://github.com/ember-cli/babel-plugin-filter-imports/pull/64

alexlafroscia commented 5 years ago

With the update to babel-plugin-filter-imports that was just released, I think this should actually be ready to go!