search

ember-decorators / argument

Decorators for Component and Object arguments in Ember
MIT License
30 stars 18 forks source link

Support Babel 7 #84

Closed alexlafroscia closed 5 years ago

alexlafroscia commented 5 years ago

Closes #75 Replacement for #80

Note: this is a breaking change because of the dropped support for ember-cli-babel@6

alexlafroscia commented 5 years ago

It looks like something is introducing both decorators and decorators-legacy again... 😡

alexlafroscia commented 5 years ago

Closing; I think it's going to be easier to start over on the new, simplified version instead.

thec0keman commented 5 years ago

Hey, thanks for your work on this. I was curious to see how this worked in our app, and while everything builds, components throw an error:

An element descriptor's .kind property must be either "method" or "field", but a decorator created an element descriptor with .kind "undefined"

If this isn't related to your work here, then please disregard. Just wanted to bring it up in case it was helpful.

alexlafroscia commented 5 years ago

The problem is that @ember-decorators/babel-transforms now uses the stage-2 decorators proposal, and this repo currently targets the stage-1 proposal. If your'e using babel-transforms@3 then you'll see that error!

I'm working on a total re-write of this addon at #83, which will include making the decorator work with the stage-2 decorator proposal and Babel 7.