search

ember-fastboot / ember-cli-fastboot

Server-side rendering for Ember.js apps
http://ember-fastboot.com/
MIT License
851 stars 160 forks source link

An in-range update of eslint-plugin-ember is breaking the build 🚨 #642

Open greenkeeper[bot] opened 5 years ago

greenkeeper[bot] commented 5 years ago

The devDependency eslint-plugin-ember was updated from 5.2.0 to 5.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-ember is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **continuous-integration/travis-ci/push:** The Travis CI build is in progress ([Details](https://travis-ci.org/ember-fastboot/ember-cli-fastboot/builds/452571055?utm_source=github_status&utm_medium=notification)). - ❌ **continuous-integration/appveyor/branch:** AppVeyor build failed ([Details](https://ci.appveyor.com/project/embercli/ember-cli-fastboot/builds/20157527)).
FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 5.2.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 5 years ago

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 7 commits.

  • 390c39c 5.4.0
  • 7f159e6 Add v5.4.0 to CHANGELOG.
  • af63958 Merge pull request #314 from gmurphey/add-new-rules-to-index
  • 81a80a0 Adding missing rules to index.js. Fixes #313.
  • 37ecb40 Merge pull request #253 from twokul/needs
  • ba92b28 Reset recommended change until major bump.
  • 4ad5b86 avoid-using-needs rule

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Commits

The new version differs by 76 commits.

  • 0e4236c 6.1.0
  • 4d2b012 Add v6.1.0 to CHANGELOG.
  • 5fa1aca Merge pull request #350 from dfreeman/no-ember-super-in-es-classes
  • d3221b6 Merge pull request #353 from nlfurniss/fix-spread-issue
  • 14a4a2d Fix error thrown when avoid-leaking-state-in-ember-objects comes upon a spread operator
  • 9d79ca4 Bump ember-rfc176-data from 0.3.5 to 0.3.6 (#352)
  • f07e5b0 Merge pull request #349 from samselikoff/patch-1
  • 964b98c Don't recommend no-ember-super-in-es-classes right out of the gate
  • 9e43aac Update avoid-leaking-state-in-ember-objects.md
  • 71195ce Introduce no-ember-super-in-es-classes rule
  • 89fd8ff Merge pull request #348 from scalvert/fix-no-restricted-resolver-rule
  • 5fff1df Update avoid-leaking-state-in-ember-objects.md
  • d0af03f Fix no-restricted-resolver-tests to narrow scope of rule
  • 69238d9 Merge pull request #347 from Turbo87/travis-sudo
  • d347646 TravisCI: Remove deprecated sudo: false option

There are 76 commits in total.

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are still failing with this version. Compare changes

Release Notes for v6.3.0

🚀 Enhancement

  • #369 Add new 'route-path-style' rule (@bmish)
  • #372 Add new 'no-unnecessary-index-route' rule (@bmish)
  • #262 Add new 'require-return-from-computed' rule (@gmurphey)
  • #378 Add new no-unnecessary-service-injection-argument rule (@bmish)

📝 Documentation

  • #395 docs: improve closure-action rule examples (@Caltor)
  • #383 no-deeply-nested-dependent-keys-with-each: Fix documentation examples (@Alonski)

🏠 Internal

  • #386 test: add null output assertions for lint rules / test cases with no autofixer. (@bmish)

Committers: 4

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.4.0

🚀 Enhancement

🐛 Bug Fix

  • #398 no-unnecessary-route-path-option: fix error when path is undefined (@bmish)

📝 Documentation

Committers: 2

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.4.1

🐛 Bug Fix

  • #413 Ignore template literals in no-get and no-get-properties rules (@bmish)

Committers: 1

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.5.0

🚀 Enhancement

  • #421 Update the no-get rule to also handle the getProperties function, and mark the no-get-properties rule as deprecated (@bmish)
  • #397 Add new computed-property-getters rule (@jrjohnson)

📝 Documentation

Committers: 2

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.5.1

🐛 Bug Fix

  • #427 Fix typo in error message for no-get rule (@bmish)

Committers: 1

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for Release 6.7.0

v6.7.0 (2019-06-22)

🚀 Enhancement

  • #436 Adds decorator rules to aid migration to Octane (@pzuraq)
  • #434 Add new no-volatile-computed-properties rule (@bmish)

🐛 Bug Fix

  • #432 Update require-computed-macros rule to suggest the reads macro instead of readOnly for computed properties with return this.x (@bmish)

🏠 Internal

Committers: 4

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.7.1

🐛 Bug Fix

  • #440 Add missing rules classic-decorator-hooks and classic-decorator-no-classic-methods to index.js (@bmish)

Committers: 1

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.8.2

🐛 Bug Fix

  • #461 Add null check in new-module-imports rule (again) (@bmish)

Committers: 1

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.9.0

🚀 Enhancement

  • #458 Add new rule require-computed-property-dependencies (@bmish)

🐛 Bug Fix

  • #463 Fix false positives for import statements with use-ember-data-rfc-395-imports rule (@fusion2004)

🏠 Internal

  • #465 Add tests that rules are setup correctly (not missing tests, docs, exports, etc) (@bmish)
  • #466 Fix eslint 6 rule test parser error (@bmish)

Committers: 2

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.9.1

🐛 Bug Fix

  • #472 Improve handling of nested keys inside braces for require-computed-property-dependencies rule (@bmish)
  • #471 Improve detection of missing dependencies in require-computed-property-dependencies rule (@bmish)

Committers: 1

greenkeeper[bot] commented 5 years ago

Your tests are still failing with this version. Compare changes

Release Notes for v6.10.0

🚀 Enhancement

  • #473 Add new no-incorrect-calls-with-inline-anonymous-functions rule (@raycohen)

🐛 Bug Fix

  • #476 Add allowDynamicKeys option (default true) to require-computed-property-dependencies rule (@bmish)

Committers: 2

greenkeeper[bot] commented 5 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v6.10.1

🐛 Bug Fix

  • #488 Update require-computed-property-dependencies rule to support eslint 3 and 4 (@bmish)

📝 Documentation

  • #489 Document eslint 4 as the minimum supported version (@bmish)

🏠 Internal

  • #482 Start testing plugin under Node 12 (@bmish)

Committers: 1

Commits

The new version differs by 15 commits.

  • 362b42b v6.10.1
  • 60e1dce Update CHANGELOG
  • 84b2469 Merge pull request #489 from bmish/eslint-4-minimum-version
  • a2bf4bd Revert "chore(dev-deps): upgrade to eslint 5.16.0"
  • c8e6d0d docs: Document eslint 4 as the minimum supported version
  • 8eb61cf Merge pull request #488 from bmish/require-computed-property-dependencies-eslint4-fix
  • f317d94 fix: update require-computed-property-dependencies rule to work in eslint 3 and eslint 4
  • f2b96cb Merge pull request #483 from bmish/script-lint-js
  • 6a87c5e Merge pull request #482 from bmish/test-node-12
  • bcef6ea Add yarn lint:js script which is called by yarn lint.
  • 29c84ff test: start testing plugin under Node 12
  • 2a5f4d3 Merge pull request #480 from bmish/bmishkin/readme-remove-node-6
  • 40a5bed build(deps-dev): bump jest from 24.8.0 to 24.9.0 (#474)
  • 498b704 build(deps-dev): bump eslint-config-prettier from 6.0.0 to 6.1.0 (#481)
  • 2bc6ca9 docs: update supported Node versions mentioned in README

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are still failing with this version. Compare changes

Release Notes for v7.11.0

🚀 Enhancement

  • #695 Add new rule no-incorrect-computed-macros (@bmish)
  • #709 Add new rule no-invalid-dependent-keys (@TheMBTH)
  • #718 Add new rule no-replace-test-comments (@jaydgruber)
  • #705 Support TypeScript files when checking if rules are running on Ember module or test files (@bmish)

🐛 Bug Fix

  • #719 Validate imports before reporting violations in no-invalid-debug-function-arguments rule (@bmish)

📝 Documentation

  • #716 Revamp the guide for contributing a new rule (@bmish)
  • #715 Mention if a rule is auto-fixable in its documentation (@bmish)
  • #713 Add tests to ensure each rule documentation file has the right title and an examples section (@bmish)
  • #711 Improve contribution guide for adding new rules (@TheMBTH)

🏠 Internal

  • #720 Add tests to ensure some computed property rules handle the @computed decorator (@bmish)

Committers: 3

Commits

The new version differs by 443 commits.

  • f2e1feb v7.11.0
  • 9018fba Update CHANGELOG
  • acb2d67 Merge pull request #720 from bmish/computed-decorators
  • a8d5237 tes: add tests to ensure some computed property rules handle the computed decorator
  • 4791818 Merge pull request #719 from bmish/no-invalid-debug-function-arguments-check-imports
  • e7ac741 fix: add import checking to no-invalid-debug-function-arguments
  • 9779724 Merge pull request #695 from bmish/no-incorrect-computed-macros
  • 78d8ec4 Merge pull request #709 from TheMBTH/ISSUE-708
  • d177089 Apply suggestions from code review
- [`2a5ea22`](https://github.com/ember-cli/eslint-plugin-ember/commit/2a5ea224029cb86f1282beca44f605cb9421dc80) Apply suggestions from code review - [`4866534`](https://github.com/ember-cli/eslint-plugin-ember/commit/48665341c1cbfbd6ef418f9e2910e08cba413eeb) Add new rule `no-replace-test-comments` (#718) - [`8e5e632`](https://github.com/ember-cli/eslint-plugin-ember/commit/8e5e6326049e5881fb726bec19e039fcd2440d84) feat: add new rule no-incorrect-computed-macros - [`40c12a2`](https://github.com/ember-cli/eslint-plugin-ember/commit/40c12a229b5f54836cefba277e26536230f9b05f) ISSUE #708 - Add rule "no-invalid-dependent-keys" to require that dependent keys used for computed properties to be valid. - [`2029651`](https://github.com/ember-cli/eslint-plugin-ember/commit/2029651e09134f4662267c0c75f8e5f7f1651c5f) docs: fix parentheses - [`0d88793`](https://github.com/ember-cli/eslint-plugin-ember/commit/0d887938824496bcde6bf5d2ab4efe32b141e471) Merge pull request #716 from bmish/docs-new-rule-rewrite

There are 250 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v7.11.1

🐛 Bug Fix

  • #728 Allow brace expansion with and, or macros in no-incorrect-computed-macros rule (@bmish)

📝 Documentation

  • #724 Recategorize rules in README (@bmish)
  • #723 Sort rule categories alphabetically in README (@bmish)

Committers: 1

Commits

The new version differs by 14 commits.

  • ccd91d0 v7.11.1
  • 7febf8e Update CHANGELOG
  • 40018aa Merge pull request #728 from bmish/fix-no-incorrect-computed-macros-brace-expansion
  • 46e2d14 fix: allow brace expansion with and, or in no-incorrect-computed-macros rule
  • a30c342 Merge pull request #724 from bmish/categories-reorganize
  • c73d0f6 build(deps-dev): bump eslint-config-prettier from 6.10.0 to 6.10.1 (#726)
  • 18dcc1a docs: recategorize rules into new groups
  • 1a1d7a3 docs: use case-insensitive sorting of rule categories in README
  • 0f72605 Merge pull request #723 from bmish/docs-sort-categories
  • bde15c0 docs: sort README rule categories alphabetically
  • 237c8fc Merge pull request #722 from bmish/rule-desc-tweaks
  • 17634d3 docs: tweak some rule descriptions for clarity
  • 294f7d0 Merge pull request #721 from bmish/docs-readme-new-rule-eslint-link
  • dfa0d06 docs: add link to eslint 'working with rules' doc in README

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v7.12.0

🚀 Enhancement

  • #738 Use sets instead of arrays for better performance (@bmish)
  • #702 Add new rule no-invalid-test-waiters (@scalvert)

📝 Documentation

  • #737 Mention tracked properties as a fix for classic-decorator-no-classic-methods (@bmish)

🏠 Internal

Committers: 2

Commits

The new version differs by 33 commits.

  • fde159f v7.12.0
  • a6e4dda Update CHANGELOG
  • e7b972f Merge pull request #737 from bmish/classic-decorator-no-classic-methods-tracked-properties
  • 00dc010 Merge pull request #739 from bmish/no-invalid-test-waiters-fix-crashes
  • d5c95c7 Merge pull request #740 from ember-cli/bmish-docs-no-invalid-test-waiters-examples
  • 3c443e5 Improve examples for no-invalid-test-waiters rule
  • e987200 Update docs/rules/classic-decorator-no-classic-methods.md
  • ac32425 fix: fix crashes in no-invalid-test-waiters rule
  • ae0e187 Merge pull request #738 from bmish/set-not-array
  • c6f1ea2 refactor: use sets instead of arrays for better performance
  • 712a9ec Merge pull request #702 from scalvert/use-waiters-in-module-scope
  • ae56cc7 docs: mention tracked properties as a fix for classic-decorator-no-classic-methods
  • 7f1059f build(deps-dev): bump jest from 24.9.0 to 25.2.3 (#735)
  • f377dac Merge pull request #732 from bmish/test-node-13
  • 5969015 test: begin testing under Node 13

There are 33 commits in total.

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for v7.13.0

🚀 Enhancement

  • #742 Detect invalid position of @each or [] in no-invalid-dependent-keys rule (@bmish)

🏠 Internal

  • #741 Switch from Travis to GitHub Actions for CI (@bmish)

Committers: 1

Commits

The new version differs by 39 commits.

  • 17f8c8d v7.13.0
  • d191ac1 Update CHANGELOG
  • fb055e9 Merge pull request #742 from bmish/no-invalid-dependent-keys-invalid-at-each-brackets
  • 6de1c50 feat: detect invalid position of @each or [] in no-invalid-dependent-keys rule
  • 61db683 Merge pull request #741 from ember-cli/bmish-github-actions
  • 248686b test: switch from Travis to GitHub Actions for CI
  • fde159f v7.12.0
  • a6e4dda Update CHANGELOG
  • e7b972f Merge pull request #737 from bmish/classic-decorator-no-classic-methods-tracked-properties
  • 00dc010 Merge pull request #739 from bmish/no-invalid-test-waiters-fix-crashes
  • d5c95c7 Merge pull request #740 from ember-cli/bmish-docs-no-invalid-test-waiters-examples
  • 3c443e5 Improve examples for no-invalid-test-waiters rule
  • e987200 Update docs/rules/classic-decorator-no-classic-methods.md
  • ac32425 fix: fix crashes in no-invalid-test-waiters rule
  • ae0e187 Merge pull request #738 from bmish/set-not-array

There are 39 commits in total.

See the full diff