search

ember-fastboot / ember-cli-fastboot

Server-side rendering for Ember.js apps
http://ember-fastboot.com/
MIT License
852 stars 160 forks source link

replace term whitelist with allowlist #806

Open mcfiredrill opened 3 years ago

mcfiredrill commented 3 years ago

I followed the RFC from awhile back that has since been merged, so hopefully this can be changed here in ember-cli-fastboot as well.

kiwiupover commented 3 years ago

@mcfiredrill thank you so much for your PR. I really want to make sure that we land it soon.

To fix the test failures we there needs to be an update to the underlying fastboot module. You can see that here: https://github.com/ember-fastboot/fastboot/search?q=whitelist

We are in the process of pulling all the fastboot packages together into one repo which will make this PR much easier to land. Once #805 is merge then this PR will be very easy to make the change across all the fastboot packages.

mcfiredrill commented 3 years ago

Great thank you! Sorry I didn't have time to look into the test failures yet.

To fix the test failures we there needs to be an update to the underlying fastboot module. You can see that here: https://github.com/ember-fastboot/fastboot/search?q=whitelist

Makes sense. Is it worth making a PR to ember-fastboot to fix , or maybe it's better to wait until the monorepo is setup?

kiwiupover commented 3 years ago

@mcfiredrill Hello we just merged the monorepo branch please feel free to update your PR.

We would like to use the name allowedHosts going forward. Does that make sense?

Thanks for your help here.