search

ember-fastboot / ember-cli-fastboot

Server-side rendering for Ember.js apps
http://ember-fastboot.com/
MIT License
852 stars 160 forks source link

Update node engine requirement #824

Closed xg-wang closed 2 years ago

xg-wang commented 3 years ago

https://nodejs.org/en/about/releases/

Release Status Codename Initial Release Active LTS Start Maintenance LTS Start End-of-life
v10 Maintenance LTS Dubnium 2018-04-24 2018-10-30 2020-05-19 2021-04-30
v12 Maintenance LTS Erbium 2019-04-23 2019-10-21 2020-11-30 2022-04-30
v14 Active LTS Fermium 2020-04-21 2020-10-27 2021-10-19 2023-04-30
v15 Current   2020-10-20   2021-04-01 2021-06-01
v16 Pending   2021-04-20 2021-10-26 2022-10-18 2024-04-30
mansona commented 3 years ago

So i did a little bit of investigating and it seems like there might be somehting wrong with Babel and the promise polyfil 🤔

Screenshot 2021-05-31 at 17 32 14

That is an array that is being passed into validateObject (which fails if you don't pass in an object)

Interestingly I had a different error that I needed to workaround before I even go that far and it was caused by a file that has actually been removed from ember-cli in v3.17, so I wonder if the root of our issue is that we are in a very outdated ember-cli version 🤔

mansona commented 2 years ago

this was included in https://github.com/ember-fastboot/ember-cli-fastboot/pull/834 👍