search

ember-fastboot / ember-cli-fastboot

Server-side rendering for Ember.js apps
http://ember-fastboot.com/
MIT License
852 stars 160 forks source link

Add a default state for metadata #840

Closed suchitadoshi1987 closed 2 years ago

suchitadoshi1987 commented 2 years ago

Currently ember addons that rely on certain metadata from fastboot service that depends on a transitive dependency that sets this metadata will run into issues during local development against a dummy app. This PR adds the default value of the metadata so that the invocation of the meta doesnt hard fail.

kratiahuja commented 2 years ago

Should we add a test for the default value ? This way in future if we accidentally change this, then we have a test to back this up.

kratiahuja commented 2 years ago

Also would be good to run this by @rwjblue first

suchitadoshi1987 commented 2 years ago

cc @rwjblue

suchitadoshi1987 commented 2 years ago

Should we add a test for the default value ? This way in future if we accidentally change this, then we have a test to back this up.

yup. added tests to ensure ^^

kratiahuja commented 2 years ago

LGTM! thanks for adding the tests

xg-wang commented 2 years ago

@suchitadoshi1987 I think we need to avoid creating new test fixtures here. I'll DM you to figure out the unit test or use a proper test app

xg-wang commented 2 years ago

@suchitadoshi1987 looks like this change broke existing test https://github.com/ember-fastboot/ember-cli-fastboot/pull/843/checks?check_run_id=3259458760