search

ember-fastboot / ember-cli-fastboot

Server-side rendering for Ember.js apps
http://ember-fastboot.com/
MIT License
851 stars 159 forks source link

Add ember-try testing for ember-cli-fastboot #858

Closed mansona closed 3 years ago

mansona commented 3 years ago

This is also adding some "no-deprecations" tests so that hopefully we can see that #857 will actually fix things objectively 😂

Edit: this looks like it's doing its job. The no-deprecations (and the beta/canary builds) are failing because of the deprecation that people are reporting.

I'm personally not sure what the value is to having all of the ember-try scenarios that this PR defines 🤔 but I think that we could potentially combine this PR with #857 and get a better feel if we've caught all of the places that show the deprecation 👍

NullVoxPopuli commented 3 years ago

anything keeping this from being merged? it'd be a requirement for further updating for ember 4 support (require ember-auto-import@v2)