search

ember-fastboot / ember-cli-fastboot

Server-side rendering for Ember.js apps
http://ember-fastboot.com/
MIT License
852 stars 160 forks source link

Ensure rehydration works on Ember < 3.27 #862

Closed rwjblue closed 2 years ago

rwjblue commented 2 years ago

The fallback for the guard introduced in 32d6f074c66aed32898a05934dad24b4b8cb19e4 (which takes effect when running on Ember < 3.27) is somewhat fundamentally borked. Due to the usage of var Ember and the fact that var hoists, the fallback in the ternary can never anything but undefined.

rwjblue commented 2 years ago

This likely fixes the thing that @snewcomer mentioned in https://github.com/ember-fastboot/ember-cli-fastboot/pull/849#issuecomment-903782779 (when I was debugging with @scalvert it present in the same way that Scott mentioned).

rahulk94 commented 2 years ago

@rwjblue I just ran into this whilst trying to use Fastboot beta 4 with a Ember 3.24.x app. Can you look at doing a beta release sooner than later?

Edit: looks like beta 5 is out now 🤙🏾