search

ember-fastboot / ember-cli-fastboot

Server-side rendering for Ember.js apps
http://ember-fastboot.com/
MIT License
852 stars 160 forks source link

Fix ci and get working with Ember 5 #916

Closed Gaurav0 closed 10 months ago

Gaurav0 commented 1 year ago

Merges https://github.com/ember-fastboot/ember-cli-fastboot/pull/898 , https://github.com/ember-fastboot/ember-cli-fastboot/pull/907, and https://github.com/ember-fastboot/ember-cli-fastboot/pull/915

fastboot-shoebox-test was broken by https://github.com/ember-fastboot/ember-cli-fastboot/pull/905

Only one test is failing, and it is due to this bug: https://github.com/emberjs/ember.js/issues/20377

Update: the test is "Fixed", but only because the current release is now Ember 5.0

gilest commented 1 year ago

Nice work @Gaurav0 !

How can we help with this? I'm happy to do some testing with existing apps.

mansona commented 10 months ago

I'm closing this for now. I've looked into it and it seems like the fix is in the wrong place. Also the PR is too big to realistically review properly.

For anyone following this work I'm taking back up the mantle of fixing ember-cli-fastboot this week so don't worry about this getting lost 👍