search

ember-fastboot / ember-cli-fastboot

Server-side rendering for Ember.js apps
http://ember-fastboot.com/
MIT License
851 stars 159 forks source link

Unnecessary package duplication #951

Open ef4 opened 2 months ago

ef4 commented 2 months ago

If you install ember-cli-fastboot 4.1.5, you will always get two different versions of fastboot in your dependency graph:

ember-cli-fastboot 4.1.5
├── fastboot 4.1.5
└─┬ fastboot-express-middleware 4.1.2
  └── fastboot 4.1.2

This is because workspace:* dependencies become exact version matches when published.

It would probably be better to use workspace:^.

SergeAstapov commented 2 months ago

Related PR https://github.com/ember-fastboot/ember-cli-fastboot/pull/948

i can update it with suggestion to use caret everywhere

mansona commented 2 months ago

@SergeAstapov yes if you update it to a ^ everywhere, I would merge that 👍

I wasn't confident enough to merge your other PR because I didn't have a real example of the effect, and Ed's example shows that we probably want to minimise the duplication 👍