Closed jasonmit closed 8 years ago
Closing, I was reopening Ember.Component and adding an attribute binding which effected ember-cli-head's component.
ember.debug.js:15157 Uncaught Error: Assertion Failed: Cannot append multiple root views
EmberError @ ember.debug.js:15157
assert @ ember.debug.js:5760
assert @ ember.debug.js:14926
_renderRoot @ ember.debug.js:10082
appendOutletView @ ember.debug.js:10010
appendTo @ ember.debug.js:13199
didCreateRootView @ ember.debug.js:2918
_setOutlets @ ember.debug.js:25825
invoke @ ember.debug.js:1064
flush @ ember.debug.js:1128
flush @ ember.debug.js:936
end @ ember.debug.js:250
(anonymous function)
So after resolving the above issue, another issue popped up that I don't believe has to do with my app code and appears to only happen with ember-cli-head enabled.
Dang. The appendTo implementation here was always slightly unorthodox to get the job done. If that's no longer viable we'll need to find an alternative. I just went on vacation so won't be able to dig in for over a week. If you have any insights/solutions I'm happy to give them a look.
On Thu, Sep 1, 2016 at 6:00 PM Jason Mitchell notifications@github.com wrote:
Reopened #10 https://github.com/ronco/ember-cli-head/issues/10.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ronco/ember-cli-head/issues/10#event-775841522, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlbJHKJwQtlcWyUqMv7KgQhCciAK_d5ks5ql0r1gaJpZM4JzK4G .
Hey, fellow appendTo
user here. There have been some recent commits in Ember to support multiple top level components (these are in Canary today). I have a feeling that this issue may be resolved now.
@mitchlloyd could you point me to the PR/commits so I can validate my ember build has the change?
This was tested on ember#alpha today.
Edit: found it https://github.com/emberjs/ember.js/pull/14179
@jasonmit did that fix it?
@chancancode no longer seeing the issue. Thanks everyone.
Currently fails on glimmer2 with this, I'll try and dig into the issue but I don't believe ember-cli-head uses attributeBindings anywhere so it may be an upstream bug.