search

ember-fastboot / ember-cli-head

Ember Cli Addon for Adding Content to HTML Head
MIT License
98 stars 34 forks source link

Fastboot deprecation #29

Closed oskarrough closed 7 years ago

oskarrough commented 7 years ago

Hi, seeing this with ember-cli-fastboot 1.0.0 rc.2 and ember-cli-head 0.2.2.

DEPRECATION: Having fastboot specific code in app directory of 
/Users/xxx/Sites/xxx/node_modules/ember-cli-head is deprecated. Please move it to fastboot/app directory.

I think it is this https://gist.github.com/kratiahuja/d22de0fb1660cf0ef58f07a6bcbf1a1c#addon-containing-fastboot-based-initializers-as-appinstance-initializersfastbootjs

Also see https://github.com/ember-fastboot/ember-cli-fastboot/issues/387#issuecomment-304445510

kratiahuja commented 7 years ago

This is already fixed with : https://github.com/ronco/ember-cli-head/pull/21 Can you provide a reproduction?

kratiahuja commented 7 years ago

Deprecation path seems wrong too: /Users/xxx/Sites/xxx/node_modules/ember-cli-head

oskarrough commented 7 years ago

The xxx part is my username. Or is the path otherwise wrong?

Here's a reproduction: https://github.com/oskarrough/fastboot-head-test. Thank you!

kratiahuja commented 7 years ago

The path is wrong.

kratiahuja commented 7 years ago

That is just a warning since we are doing the auto migration for you. Once addons and fastboot drop support for pre fastboot 1.0, they can address this deprecation.

Your app would still work.

oskarrough commented 7 years ago

It does work :) I just wanted to help fix the deprecation.

cibernox commented 7 years ago

@oskarrough I believe I closed this in #32

oskarrough commented 7 years ago

@cibernox confirmed. Thanks!