Refactor instance-initializer

ember-fastboot / ember-cli-head

Ember Cli Addon for Adding Content to HTML Head

MIT License

98 stars 34 forks source link

Refactor instance-initializer #45

Closed mydea closed 6 years ago

mydea commented 6 years ago

This PR does two main things:

Update dependencies of this addon
Fix #41 by removing the instance-initializer

Basically, in lazy loading engines, the instance initializer will run whenever another engine is entered, thus trashing the head.

This PR changes this, so that the head is trashed in the init() hook of the head-layout component. In addition to fixing this issue, it should also make it much easier to overwrite/adapt this behavior for special requirements.

mydea commented 6 years ago

I removed the extra function in the instance initializer and moved the comments down!

mydea commented 6 years ago

I adjusted the import paths for the head-layout component according to your suggestions :)

mydea commented 6 years ago

Could we get a new release with that fix? That would be great!

rwjblue commented 6 years ago

So sorry @mydea, I completely lost track of this! It has been released as 0.4.1...