search

ember-fastboot / ember-cli-head

Ember Cli Addon for Adding Content to HTML Head
MIT License
98 stars 34 forks source link

Meta elements "ember-cli-head-start" and "ember-cli-head-end" missing "content" attribute #47

Closed samcic closed 6 years ago

samcic commented 6 years ago

The HTML 5.2 Spec, section 4.2.5 ("The meta element") states that:

If either name or http-equiv is specified, then the content attribute must also be specified. Otherwise, it must be omitted.

In ember-cli-head/addon/templates/components/head-layout.hbs, the content attribute is missing from the "ember-cli-head-start" and "ember-cli-head-end" meta tags.

The w3 validator will show this as an error:

showing results for http www skedda com nu html checker

To fix this, can the content attribute simply be added with an empty string?

rwjblue commented 6 years ago

Thanks for reporting! Yes, I think an empty content attribute would be perfect.

samcic commented 6 years ago

Is it necessary to cover the changes in this PR in the unit/integration tests?