search

ember-fastboot / ember-cli-head

Ember Cli Addon for Adding Content to HTML Head
MIT License
98 stars 34 forks source link

Migrate to `{{#in-element}}` (from emberjs/rfcs#287) #71

Closed gitKrystan closed 4 years ago

gitKrystan commented 4 years ago

The private {{-in-element}} helper was deprecated in Canary, so we are seeing the following test failures in our canary tests:

The use of the private `{{-in-element}}` is deprecated, please refactor to the public `{{in-element}}`. ('ember-cli-head/templates/components/head-layout.hbs' @ L1:C0)

Using ember-in-element-polyfill should fix that.

gitKrystan commented 4 years ago

NOTE: ember-in-element-polyfill does not support node 6 or 8, so merging this requires dropping support for node 6 and 8.

chancancode commented 4 years ago

This should pass now once #73 lands and this rebase on top of that

gitKrystan commented 4 years ago

Rebased.

rwjblue commented 4 years ago

Thank you @gitKrystan!

chancancode commented 4 years ago

@rwjblue can we cut a new (major?) release from master? or I can do it too once #72 is done