ember-fastboot / ember-cli-head

Ember Cli Addon for Adding Content to HTML Head
MIT License
98 stars 34 forks source link

Drop support for Node < 10 and Ember < 2.18. #73

Closed chancancode closed 4 years ago

chancancode commented 4 years ago

See https://github.com/chancancode/ember-cli-head/pull/1/checks for the GitHub Actions runs. They should start showing up here once this lands. Canary tests are currently failing, should be fixed by #71.

chancancode commented 4 years ago

See https://github.com/chancancode/ember-cli-head/pull/1/checks for the GitHub Actions runs

simonihmig commented 4 years ago

Seems this is now configured to throw on deprecations, so canary is failing due to -in-element. In that case the changes from #71 would also need to be pulled in, right?

chancancode commented 4 years ago

Yep exactly. But since none of the checks are required (or even running on this repo), we can probably just merge this and rebase #71 on top. Would be a good excuse to test out the new CI setup in the context of a PR.