search

ember-fastboot / fastboot-app-server

A production-ready app server for running Ember FastBoot apps
140 stars 72 forks source link

Bump fastboot #102

Closed lucacorti closed 5 years ago

lucacorti commented 5 years ago

I have tested that bumping fastboot and fastboot-express-middleware fixes the issue I'm experiencing with ember-fetch, fastboot-app-server and ember-data@3.9 reported here ember-fastboot/ember-cli-fastboot/issues/686.

lucacorti commented 5 years ago

I aligned the travis test matrix to bring it in line with current fastboot node releases. Also, fastboot-express-middleware needs a release with bumped fastboot I think.

snewcomer commented 5 years ago

@lucacorti This looks good! Is a new release of fastboot-express-middleware required before merging this?

lucacorti commented 5 years ago

@snewcomer I don't think a release of fastboot-express-middleware is strictly needed, this is sufficient, but would be nice to get rid of the fastboot 1.x dependecy.

SergeAstapov commented 5 years ago

@kratiahuja could this be merged and new version released if possible, please?

kratiahuja commented 5 years ago

@SergeAstapov I am very sorry for the delay. I am happy to merge this PR. cc: @locks not sure I understand your suggestion, but the diff looks fine to me. Please let me know if I am ready this incorrectly.

kratiahuja commented 5 years ago

Thank you @lucacorti and apologies for the delay again. I'll get a release out tonight cc @rwjblue

lucacorti commented 5 years ago

@kratiahuja Great, thanks! Would be great if you could also roll a new release for fastboot-express-middleware and bump that dependency too.

locks commented 5 years ago

@kratiahuja I was removing Node 6 since it's no longer a supported version, but it can be done afterwards!

kratiahuja commented 5 years ago

@locks apologies for that, I'll didn't realize it. I'll send in a PR for the same tomorrow.

@lucacorti Sure let me look into that after releasing this.

snewcomer commented 5 years ago

🎉 Yayyy! FYI #105 is ready to go that drops 6. Thank you again!

kratiahuja commented 5 years ago

Sorry for the delay, I have a PR for bumping fastboot-express-middleware: https://github.com/ember-fastboot/fastboot-app-server/pull/109, once the tests pass for that, I'll merge and release fastboot-app-server@2.0.0

kratiahuja commented 5 years ago

fastboot-app-server@2.0.0 is published 🎉