search

ember-fastboot / fastboot-s3-downloader

A FastBoot App Server downloader for AWS S3
7 stars 24 forks source link

Allow to set AWS region #3

Closed bobisjan closed 7 years ago

bobisjan commented 7 years ago

👀 @tomdale

simonihmig commented 7 years ago

Btw, also had the problem that I wanted to use a S3 bucket from another region. However #6 was all that I needed to make it work!?

bobisjan commented 7 years ago

Changing signature version in #6 should work well. I would still prefer to allow to set region by user, if I know where the bucket lives, to remove roundtrip through the default (us-east-1) region.

simonihmig commented 7 years ago

Ah, I see, makes sense! 👍

bobisjan commented 7 years ago

@tomdale, resolved conflicts, ready to review ☺️.

tomdale commented 7 years ago

Thank you!