search

ember-forge / ember-forge-ui

Ember.js UI Components that are independent of any specific CSS framework
MIT License
1 stars 2 forks source link

Move the manageLabelAttribute() functionality from fieldset to the form #156

Open notmessenger opened 8 years ago

notmessenger commented 8 years ago

Beyond just moving it it will require modification to the logic as well. For each <label> found without a populated for attribute find the closest (DOM-wise) labelable element with a set id that is not already assigned to a <label>'s for attribute and assign its id value to the for attribute.

Can likely schedule for 'afterRender' but find the appropriate run event queue.

notmessenger commented 8 years ago

The logic has already been removed from ef-fieldset but still needs to be modified and added to ef-form.

https://github.com/ember-forge/ember-forge-ui/commit/7a76525af454cad60cb68d6fe782f69c617513cd removed it.