Closed bzf closed 3 years ago
This fixes the issue we are experiencing at work, but I know very little about webpack and used @achambers suggestion in #389 to help move this forward. Hope that's ok 😊
Thank you @bzf. Published in v3.1.1.
I think this is still needed, because if a user imports anything from apollo, like error classes, they run into the error without this config. Maybe the solution is to codemod in the blueprint? And anyone using react can remove it.
@knownasilya there are two alternatives to avoid this issue:
@apollo/client/core
. If you import from the root, it will require React, but if you require it from the core, it will not.Seems like you'd have to do both honestly, since there is no great way to enforce where you import from.
Since already we use the
@apollo/client/core
import,react
won't be included in the build.Closes https://github.com/ember-graphql/ember-apollo-client/issues/389