Closed balinterdi closed 2 years ago
We have an Ember app that runs on Embroider. I recently upgraded our app from v3.26.2
of Ember to v3.28.6
. After the upgrade, our app would not build. It failed with this message:
cleaning up...
Build Error (PackagerRunner) in node_modules/@ember/test-helpers/-internal/debug-info.js
Module not found: Error: Can't resolve '@ember/test-waiters' in '$TMPDIR/embroider/39a280/node_modules/@ember/test-helpers/-internal/debug-info.js'
I was able to fix this build error by switching from the latest release of ember-apollo-client
to the fork that @balinterdi created.
It would be great to see this PR merged and included in a new release of ember-apollo-client
. Is there anything I can do to help?
@josemarluedke Is there something preventing this PR from being considered for merging?
@balinterdi sorry for the delay. This PR got into the cracks.
When building an app that has a dependency on ember-apollo-client and has Embroider switched on, I see the following error:
(This error is similar to the one discussed at https://github.com/emberjs/ember-test-waiters/issues/158)
Digging down, I've found it came from the
@ember/test-waiters
dependency thatember-apollo-client
has.The app had the following versions:
(It also failed similarly with the latest Ember CLI, 3.28).
Interestingly, it didn't fail on macOS computers, only on Linux (no idea about Windows).
Upgrading the
@ember/test-waiters
dependency to 3.0.0 fixed it so I think if tests pass, this PR is good to merge?