Closed balinterdi closed 2 years ago
@josemarluedke I wouldn't have merged this as it still fails on ember-canary (and maybe on other Ember versions, too, but they were cancelled early) 😬
I believe it's failing because ember-auto-import v1 is used and ember v4 requires v2.
If that was the case then #414 would pass, wouldn't it? 🤔
Yes, when rebased with the changes from this PR.
Published as v4.0.0.
I think the PR description is a bit confusing.
import Ember from 'ember';
was never deprecated, and the removed code works just fine in v4.
We have been using ember-apollo-client
in v4 for a while now.
That being said, using macroCondition(isTesting())
is probably better anyways to strip out testing code.
@bertdeblock You're right. I was under the impression that importing the global Ember will throw an error in Ember 4 but now I re-read the entry in the deprecation guide and it turns out that it only throws if you use Ember
without importing it.
I still think this is very valuable to have (otherwise this add-on prevents tree-shaking parts of Ember) but the description is indeed misleading, @josemarluedke sorry about that.
I still think this is very valuable to have
Yup, this seems better anyways 👍
This is one of the deprecations that prevent Ember 4 compatibility.
isTesting
can be imported from@embroider/macros
and relying on this package does not mean the add-on needs to be built with Embroider.