search

ember-graphql / ember-apollo-client

🚀 An ember-cli addon for Apollo Client and GraphQL
MIT License
279 stars 72 forks source link

Build error when using Embroider #417

Closed balinterdi closed 1 year ago

balinterdi commented 2 years ago

I'm working on a project that builds with Embroider (and uses this add-on, obviously).

Even though #404 fixed the build for us, after upgrading to 4.0, I see the same kind of error during the build phase:

Module not found: Error: Can't resolve '@ember/test-waiters' in '$TMPDIR/embroider/d44410/node_modules/ember-apollo-client/services/apollo.js'

At the same time I see the add-on is tested against Embroider "safe" and "optimized" levels so it's possible that this is just a problem in the app I'm working on 🤷🏽‍♂️

https://github.com/ember-graphql/ember-apollo-client/blob/63f0408103768001ccb77a3afe736c7d94b12e7a/config/ember-try.js#L68-L69

josemarluedke commented 2 years ago

@balinterdi The addon is actually not tested against Embroider. We need to add these to the GitHub Actions list:

https://github.com/ember-graphql/ember-apollo-client/blob/master/.github/workflows/ci.yml#L40-L47

bertdeblock commented 2 years ago

The embroider-safe and embroider-optimized scenario's seem fine over in #418. Maybe try reproducing in a fresh app?

balinterdi commented 1 year ago

Turns out this has nothing to do with ember-apollo-client. It's ember-a11y-testing that allows a version of @ember/test-helpers which has that bug.

I'm going to close this, sorry about the noise.