Replace ' with real quote marks to display correct typography - Githubissues

ember-intl / cp-validations

ember-intl support for ember-cp-validations

MIT License

10 stars 13 forks source link

Replace ' with real quote marks to display correct typography #5

Closed elwayman02 closed 8 years ago

elwayman02 commented 8 years ago

Reference: http://webdesignledger.com/common-typography-mistakes-apostrophes-versus-quotation-marks

jasonmit commented 8 years ago

You may want to send this PR upstream also

elwayman02 commented 8 years ago

Upstream...? where?

jasonmit commented 8 years ago

Where they originated from: https://github.com/offirgolan/ember-cp-validations/blob/6818d7fb11a53c59bddc0518c1f464c053591e5e/addon/validators/messages.js#L62-L92