search

ember-intl / cp-validations

ember-intl support for ember-cp-validations
MIT License
10 stars 13 forks source link

Bump ember-cli-babel from 6.7.1 to 7.26.10 #75

Closed herzzanu closed 2 years ago

herzzanu commented 2 years ago

Solves https://github.com/ember-intl/cp-validations/issues/74

herzzanu commented 2 years ago

@jasonmit @buschtoens Could you please have a look at this? 🙏 It might help a lot of people trying to upgrade to the latest Ember version.

herzzanu commented 2 years ago

Any luck we can get this one merged? 🙏

buschtoens commented 2 years ago

Sorry that this was left hanging so long. I unfortunatel didn't have a lot of time to spend on open source the past months.

I've never used @ember-intl/cp-validations myself, so I'm not really familiar with this project.

buschtoens commented 2 years ago

@herzzanu This project is somewhat irrecoverably out-of-date. I opted for regenerating it from scratch and copying over and modernizing the few actual source files: #82

Unfortunately, as you're most likely already aware, issues like qonto/ember-cp-validations#3 or usage of the Ember global in ember-cp-validations & ember-validators are blocking issues.

I'm circumventing these for local development and CI via patch-package. This will not work in production use. Users will have to ensure themselves that compatible dependency versions are used.

I would appreciate, if you could publish @qonto/ember-cp-validations to npm and also take a look at my PR #82. There are still some more compatibility issues with ember-cp-validations, that are not yet in the @qonto repo, and there are issues with ember-validators.