Closed buschtoens closed 1 year ago
@buschtoens Thanks for the work done to revive this addon :) So basically what we should do now is publish https://github.com/qonto/ember-cp-validations to npm so we can use it here? v4.0.0-beta.13.1 uses the latest version of https://github.com/offirgolan/ember-validators
Let me know if this is what we need as the next step.
Hi @jasonmit @herzzanu @Turbo87,
Wanted to follow-up on this PR. What work is needed to get this merged with main
? These changes are needed for this library to be compatible with Ember 4.x. It looks like this PR has been in limbo for a few months now.
cc: @buschtoens
@justinbaltazar I've been out of the ember community for a while but verified @buschtoens has the proper github & npm permissions to push forward this change.
Superseded by https://github.com/ember-intl/cp-validations/pull/87
This project was insanely far out of date. Simply upgrading
ember-cli-babel
(#75) unfortunately doesn't seem to cut it. Furthermore, CI has been broken for ages.Considering it's small scope, I've opted for re-generating the project from scratch by doing the following:
ember addon --yarn --skip-git --skip-npm @ember-intl/cp-validations
ember-cp-validations
qonto/ember-cp-validations
ember-validator
Unless
ember-cp-validations
&ember-validator
are published upstream with those fixes this PR cannot be published for production use.