ember-intl / cp-validations

ember-intl support for ember-cp-validations
MIT License
10 stars 13 forks source link

chore: re-generate project with latest `ember-cli` #82

Closed buschtoens closed 1 year ago

buschtoens commented 2 years ago

This project was insanely far out of date. Simply upgrading ember-cli-babel (#75) unfortunately doesn't seem to cut it. Furthermore, CI has been broken for ages.

Considering it's small scope, I've opted for re-generating the project from scratch by doing the following:

Unless ember-cp-validations & ember-validator are published upstream with those fixes this PR cannot be published for production use.

herzzanu commented 2 years ago

@buschtoens Thanks for the work done to revive this addon :) So basically what we should do now is publish https://github.com/qonto/ember-cp-validations to npm so we can use it here? v4.0.0-beta.13.1 uses the latest version of https://github.com/offirgolan/ember-validators

Let me know if this is what we need as the next step.

justinbaltazar commented 2 years ago

Hi @jasonmit @herzzanu @Turbo87,

Wanted to follow-up on this PR. What work is needed to get this merged with main? These changes are needed for this library to be compatible with Ember 4.x. It looks like this PR has been in limbo for a few months now.

cc: @buschtoens

jasonmit commented 2 years ago

@justinbaltazar I've been out of the ember community for a while but verified @buschtoens has the proper github & npm permissions to push forward this change.

fsmanuel commented 1 year ago

Superseded by https://github.com/ember-intl/cp-validations/pull/87