search

ember-intl / cp-validations

ember-intl support for ember-cp-validations
MIT License
10 stars 13 forks source link

Change import from 'ember-intl-cp-validations' to '@ember-intl/cp-validations' #88

Closed fsmanuel closed 2 years ago

fsmanuel commented 2 years ago

The following error fails the tests in #87

ember-cli: Your names in package.json and index.js should match. The addon in /home/runner/work/cp-validations/cp-validations currently have '@ember-intl/cp-validations' in package.json and 'ember-intl-cp-validations' in index.js. Until ember-cli v3.9, this error can be disabled by setting env variable EMBER_CLI_IGNORE_ADDON_NAME_MISMATCH to "true". For more information about this workaround, see: https://github.com/ember-cli/ember-cli/pull/7950.

Before:

import ValidatorsMessages from 'ember-intl-cp-validations/validators/messages';

After:

import ValidatorsMessages from '@ember-intl/cp-validations/validators/messages';

Ref https://github.com/ember-intl/cp-validations/issues/85

fsmanuel commented 2 years ago

@ijlee2 Thanks for approving. I'll do the release now and after that merge the PR.