search

ember-learn / cli-guides

Step-by-step guides and tutorials for using the ember-cli to create apps and addons
https://cli.emberjs.com
MIT License
25 stars 76 forks source link

Ember upgrade 3.16 #177

Closed vinodhrajamuralidharan closed 4 years ago

vinodhrajamuralidharan commented 4 years ago

connect https://github.com/ember-learn/cli-guides/issues/173 npm install -g ember-cli-update ember-cli-update --to 3.16

jenweber commented 4 years ago

I can replicate the errors locally with ember s --environment production, if that's helpful to know.

vinodhrajamuralidharan commented 4 years ago

@jenweber yes, I tried that already as it was failing only in the pipeline. The actual issue is when I do that, the error is on

pre-render /release/writing-addons/deploying failed with exception: FetchError: request to http://localhost/:7784undefined//localhost:7784/content/versions.json failed, reason: connect ECONNREFUSED 127.0.0.1:80

It has undefined for some reason. That's why it is failing.

jenweber commented 4 years ago

Ok, I’ll take a look at this tonight.

jayjayjpg commented 4 years ago

@jenweber @vinodhrajamuralidharan We (@mansona and me) are also currently investigating if there's an issue with prember in the Netlify build step - will keep you posted if we can resolve the issue!

jayjayjpg commented 4 years ago

@vinodhrajamuralidharan Netlify deploys are unblocked after an upgrade of the prember dependency! Can you git pull the changes and do another rebase of your feature branch onto the latest master? Then this should be ready to go already! :sparkles:

vinodhrajamuralidharan commented 4 years ago

@jayjayjpg seems it works now. Just it shows conflicts on package and package-lock.json and I don't have access permission to resolve that.

mansona commented 4 years ago

this looks like it still has conflict markers somewhere 🤔 maybe in the package-lock?

vinodhrajamuralidharan commented 4 years ago

@mansona yes it is in package-lock.json