Upgrade app to Ember 3.21 (Part 2 of 2)

[ijlee2]

Problem

Once #197 has been completed and merged, we can leverage npm-run-all to parallelize lints and tests.

After talking to @takshch, I think we can solve this issue in a slightly different manner. I've updated the TODOs below.

TODOs

Part 2. Update CI

• [ ] Install npm-run-all.

  npm install npm-run-all --save-dev

• [ ] Uninstall ember-cli-template-lint and ember-cli-eslint. Afterwards, install ember-template-lint and eslint.

  npm uninstall ember-cli-template-lint ember-cli-eslint
  npm install --save-dev ember-template-lint eslint

  If you run npm run lint:hbs or npm run lint:js, all lint checks should continue to pass.

• [ ] In package.json, create a lint script and update the test script to run tasks in parallel:

  {
    "scripts": {
      "build": "ember build --environment=production",
      "lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*",
      "lint:alex": "alex .",
      "lint:hbs": "ember-template-lint .",
      "lint:js": "eslint .",
      "lint:md": "remark . --frail",
      "start": "ember serve",
      "test": "npm-run-all --aggregate-output --continue-on-error --parallel test:*",
      "test:ember": "ember test",
      "test:node": "mocha node-tests"
    }
  }

• [ ] Simplify .travis.yml (CI script) to run npm run lint. Push a commit to check that the CI continues to pass.

  # Before
  script:
    - set -o errexit
    - npm run lint:md
    - npm run lint:alex
    - npm run lint:hbs
    - npm run lint:js
    - npm test
  
  # After
  script:
    - set -o errexit
    - npm run lint
    - npm run test

[ijlee2]

General notes: Hi, everyone. To allow more people to participate in Hacktoberfest, please claim only 1 issue labeled with Hacktoberfest in this repo (unless there are no others who can help). 🙂

Please check #hacktoberfest on Discord to find other repos that can use your help. Thanks and happy Hacktoberfest!

[takshch]

@ijlee2 I am Ember JS Developer and also wanted to contribute. Can you please guide me.

[ijlee2]

@takshch I updated the TODO instructions. Will you have a look?