Closed takshch closed 4 years ago
@ijlee2 Could you please check this pull request.
Your pull request description is a great start, I thought. I appreciated that you documented what you did (e.g. ran npm run lint:hbs
) and what you saw (no errors).
@ijlee2 Required changes are made. Please review again.
Description( Issue No - #198 ):
Note
: lint and test command are now able to parallelly run other lint and test commands starting with "lint" and "test" respectively.In
package.json
, in scripts object, "lint" variable is added in scripts object and value of "test" is changed."lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*"
"test": "npm-run-all --aggregate-output --continue-on-error --parallel test:*"
npm run lint:hbs
&npm run lint:js
all test are passed without any errors.npm run lint
all test are passed without any errorsInstalled packages(as dev dependencies):
1. ember-template-lint
2. npm-run-all
3. eslint packages
Uninstalled packages:
1. ember-cli-template-lint
2. ember-cli-eslint