Upgrade app to Ember 3.22

ember-learn / cli-guides

Step-by-step guides and tutorials for using the ember-cli to create apps and addons

https://cli.emberjs.com

MIT License

25 stars 76 forks source link

Upgrade app to Ember 3.22 #206

Closed maxwondercorn closed 3 years ago

maxwondercorn commented 4 years ago

Upgrade Ember per #197

[x] Update lint/test-related packages
[x] Update remark-related packages
[x] Update Ember addons
[x] Update Ember-related packages (packages installed by default)
[x] Update Ember with ember-cli-update

Closes #197

maxwondercorn commented 4 years ago

The Alex linting issues were also present on master

ijlee2 commented 4 years ago

Hi, @maxwondercorn. Thanks for working on upgrading the dependencies to their latest version.

When lint errors happen due to a package upgrade, I'd recommend adding the lint rule as an exception, as demonstrated in https://github.com/ember-learn/ember-website/pull/670/commits/9999b79b7a05c4b781fea2efe4d2450907a9be72. I can create a follow-up issue to fix the lint errors separately.

It looks you can edit .alexrc file. Can you try adding retext-equality to the list of allowed rules, see if this will help Travis CI to pass?

maxwondercorn commented 4 years ago

I am going to add alex disable comments for each error in the markdown files. I think it's better to be specific than globally disabling them in .alexrc

There must have some type of regression. These were not flagged the last time I did a PR. Some of the flagged words are relatively recent additions, but some have been in the guides for a couple years.

ijlee2 commented 4 years ago

Per file sounds good with me, thanks. I think ember-cli just released 3.22 version. If you'd like to upgrade the app to 3.22 instead, feel free to.

ijlee2 commented 4 years ago

@maxwondercorn Looks like the Netlify deploy build failed due to this error:

12:21:32 PM: Build Error (broccoli-persistent-filter:Babel > [Babel: @ember-data/adapter]) in @ember-data/adapter/rest.js
12:21:32 PM: /opt/build/repo/@ember-data/adapter/rest.js: Imported DEPRECATE_NAJAX from @ember-data/private-build-infra/deprecations which is not a supported flag.

I think this is the related pull request: https://github.com/emberjs/data/pull/7230 . It seems to suggest installing ember-fetch to remove the deprecation, but we already have the latest package? Hmm...

ijlee2 commented 4 years ago

According to a Discord conversation, it seems removing node_modules will help fix the error. I will clear the cache and restart the build.

ijlee2 commented 4 years ago

Yep, clearing the cache worked. ✨

maxwondercorn commented 4 years ago

I did that locally and if fixed the issue but on the Netilfy build... Glad it's now working!!

maxwondercorn commented 3 years ago

@ijlee2 all upgrade steps for the 3.21 bump are completed

ijlee2 commented 3 years ago

@maxwondercorn Thanks! I'll have a look tomorrow.