Generate a JSONAPISerializer to stop relying on the defaultSerializer behavior

ember-learn / cli-guides

Step-by-step guides and tutorials for using the ember-cli to create apps and addons

https://cli.emberjs.com

MIT License

25 stars 76 forks source link

Generate a JSONAPISerializer to stop relying on the defaultSerializer behavior #218

Closed Windvis closed 3 years ago

Windvis commented 3 years ago

Deprecation information: https://deprecations.emberjs.com/ember-data/v3.x/#toc_ember-data-default-serializers

mansona commented 3 years ago

Hey thanks for the contribution 🎉 I was wondering if it were possible to add an application serializer to Guidemaker that would solve this issue? 🤔 Guidemaker is the core-addon that powers the cli-guides, as you can see there is no code in the Ember App in this repo (other than now your Application Serializer 😂) because it is all being provided by Guidemaker: https://github.com/empress/guidemaker

Windvis commented 3 years ago

Yea sorry, I didn't really look into the details :smile:. I just noticed the warnings in the console and "fixed" it without looking at the rest of the codebase. I just found this issue: https://github.com/empress/guidemaker/issues/34 and a related PR which covers it already I think?