search

ember-learn / cli-guides

Step-by-step guides and tutorials for using the ember-cli to create apps and addons
https://cli.emberjs.com
MIT License
25 stars 76 forks source link

Remove references to Bower #247

Closed bertdeblock closed 2 years ago

bertdeblock commented 2 years ago

Since the Bower RFC implementation has been merged (I assume it will be part of the upcoming v4.2 release), I think we can start removing references to Bower from the guides?

netlify[bot] commented 2 years ago

✔️ Deploy Preview for ember-cli-guides ready!

🔨 Explore the source changes: f7c8955de48b2c1d5b680d828b849b19a112d1ac

🔍 Inspect the deploy log: https://app.netlify.com/sites/ember-cli-guides/deploys/61faaa0b05e776000875334d

😎 Browse the preview: https://deploy-preview-247--ember-cli-guides.netlify.app

locks commented 2 years ago

Are the CLI options you removed also removed in the implementation, or just deprecated? If they are just deprecated, I don't think they should be removed, even if we don't want to suggest usage of bower ;P

bertdeblock commented 2 years ago

At the moment, they are not removed nor do we display a deprecation warning when they are used (it was an open question in the RFC, but nobody mentioned something about it). I just assumed that since Bower support will be officially deprecated in v4.2, these could be removed from the docs as I thought the learning team did not want to teach APIs that are deprecated.

locks commented 2 years ago

The Bower mentions in the diff already indicate that Bower should not be used, so it is not being recommended. And the CLI command reference was asked by community members because they didn't know how to get a list of all the options. It would be strange if it didn't match the actual output of the tool, I think. I may be slightly biased because I'm working on a project that still uses Bower 😂

jenweber commented 2 years ago

Thank you for this! I would like to keep all the proposed changes, with the exception of removing it from the CLI output. So if you can undo changes to guides/advanced-use/cli-commands-reference.md, then I'm all for this. Bower's website is totally covered in warnings, and so we can back off on ours. @locks does that sound ok?

locks commented 2 years ago

I'm not sure about removing the hook, but as long as there are API docs I'm fine with what you said! [edit] in part because this is probably all going to have to be updated for addon format v2.

bertdeblock commented 2 years ago

I've reverted the changes related to the CLI output.

jenweber commented 2 years ago

API documentation for addBowerPackageToProject is here: https://ember-cli.com/api/classes/blueprint#method_addBowerPackagesToProject

I'm going to open a PR to ember-cli api docs with the sentence about Bower itself being deprecated.