search

ember-learn / cli-guides

Step-by-step guides and tutorials for using the ember-cli to create apps and addons
https://cli.emberjs.com
MIT License
25 stars 77 forks source link

Add things about pnpm #290

Closed NullVoxPopuli closed 10 months ago

NullVoxPopuli commented 1 year ago

RFC: https://github.com/emberjs/rfcs/pull/907 Implementation PR: https://github.com/ember-cli/ember-cli/pull/10287 Advancement: https://github.com/emberjs/rfcs/pull/932

This PR should wait to be reviewed until the implementation PR is done.

netlify[bot] commented 1 year ago

Deploy Preview for ember-cli-guides ready!

Name Link
Latest commit fd2a067c4a6a46e4b6c0f9b858d4cb018a3c2252
Latest deploy log https://app.netlify.com/sites/ember-cli-guides/deploys/6495e96b46353c0008803df4
Deploy Preview https://deploy-preview-290--ember-cli-guides.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

MinThaMie commented 1 year ago

@kategengler since the 5.1 release happend, does that mean we can merge this PR now? Or did you mean another release :)

kategengler commented 1 year ago

pnpm is currently behind a feature flag and wouldn't have landed in 5.1 anyway, 5.2 is the earliest

kategengler commented 10 months ago

This lands in 5.3. Since the CLI guides aren't versioned, when should this merge? cc @MinThaMie

jenweber commented 10 months ago

I think this can merge the week of the 5.3 release.