Open maxwondercorn opened 5 years ago
We really want to expand on using all the hooks too.
Blueprint hooks? Asset imports should also be included but that may make more sense in the wrapping the library example.
Is the first example the simplest and more is layered into the next one? Don't know what the thought process is.
I mean the ember-cli hooks that addons can use in index.js
@maxwondercorn I like the idea of adding gh-pages in. I think documenting.md is a good place for it to go!
In the section of the tutorial called "Making a UI component available in block form" I think you mean markup instead of markdown. Excited for the new docs... 😀
@jenweber I'm not sure this issue is valid/should remain open due to relevancy. documenting.md
does indirectly mention gh-pages using ember-cli-github-pages
Overall, I think the tutorial has most of the import topics covered but I think
isDevelopingAddon
should be mentioned as you won't see live reloads in your linked app if you make changes to the addonDevelopers are used to seeing the reloads when working on regular ember apps.
Second, it's not part of old cli docs but should we mention ember-cli-github-pages as a way to deploy to gh-pages, similar to the way ember-cli-addon-docs is mentioned?
I can do a PR if there is agreement