ember-learn / cli-guides

Step-by-step guides and tutorials for using the ember-cli to create apps and addons
https://cli.emberjs.com
MIT License
25 stars 76 forks source link

Show the ember-cli logo above the TOC #81

Open mansona opened 5 years ago

mansona commented 5 years ago

For the cli-guides we should show the ember-cli logo in the top left just above the TOC.

screenshot 2018-12-11 at 11 18 08

As we are using guidemaker for the ember-cli guides we will need to make this a configurable feature of the guidemaker-ember-template so that any other projects using the same template can optionally configure this logo

Todo

villander commented 5 years ago

@mansona I don't understand this question. Where are this logo? do you want me to put it in guidemaker-ember-template? and make it configurable?

mansona commented 5 years ago

@villander yes this would be a change to guidemaker-ember-template and it would need to be configurable (so it doesn't show up in other sites that use this template)

cah-john-ryan commented 4 years ago

Hi @mansona,

In looking through this I see that the logo exists at https://github.com/emberjs/website/blob/master/source/images/brand/ember_CLI-Light.png.

Are you ok with me creating a copy of this here: https://github.com/ember-learn/guidemaker-ember-template/tree/master/public/images/logos? I don't readily know how else I can make this asset available in the guidemaker repo without porting it over.

Regardless. I plan to try and assemble PR's for this. Thanks.