Document `setting-on-hash` deprecation

ember-learn / deprecation-app

Deprecation guides for ember.js, ember-data, and ember-cli

https://deprecations.emberjs.com/

22 stars 69 forks source link

Document `setting-on-hash` deprecation #1085

Closed bertdeblock closed 2 years ago

bertdeblock commented 2 years ago

Motivation: https://github.com/emberjs/ember.js/issues/19975

Location where the deprecation is triggered: https://github.com/glimmerjs/glimmer-vm/blob/9c44e6835d27fcc7dc0e276cf3b0ee011d1ffb90/packages/%40glimmer/runtime/lib/helpers/hash.ts#L15-L21

bertdeblock commented 2 years ago

I'm not sure how we normally handle documentation for deprecations coming from the VM, but since people will run into this (I have as well), it seems useful to have some documentation around this?

locks commented 2 years ago

I think we just absorb it into Ember.

[edit] Sorry, I pushed the wrong button!

shubham-y commented 2 years ago

Hey @locks , I would like to work on this issue

locks commented 2 years ago

Assigned!