search

ember-learn / deprecation-app

Deprecation guides for ember.js, ember-data, and ember-cli
https://deprecations.emberjs.com/
22 stars 69 forks source link

package: remove `ember-collapsible-panel` dep #1278

Closed geneukum closed 1 year ago

geneukum commented 1 year ago

At build-time, a warning is logged:

Usages of the Ember Global may be caused by an outdated ember-cli-babel
dependency. The following steps may help:
* Upgrade the following addons to the latest version:
  ...
  * ember-collapsible-panel

We do depend on the ember-collapsible-panel package, but do not appear to actually use it. For reference, it looks like it was added in Commit: aecc6b5d. and removed in Commit: dda4d0e5.

As such, we should just be able to remove the dependency instead of trying to upgrade it.

This should help along the way to achieving: https://github.com/ember-learn/deprecation-app/issues/1272.

netlify[bot] commented 1 year ago

Deploy Preview for ember-deprecations ready!

Name Link
Latest commit c93ff515cd2fdca86d07817f490a291c582f4237
Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/63d7ca5a94ff0900090940eb
Deploy Preview https://deploy-preview-1278--ember-deprecations.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.