Closed geneukum closed 1 year ago
Name | Link |
---|---|
Latest commit | 410ea22593130fa6b9e050869719fed9a6272a04 |
Latest deploy log | https://app.netlify.com/sites/ember-deprecations/deploys/63dc7b339694fa0008185859 |
Deploy Preview | https://deploy-preview-1279--ember-deprecations.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Removing the octane
line from .template-lintrc.js
should fix the failing test.
The failing linter command was npm run lint:hbs
. I'm not sure why this PR's change in particular makes us hit that. I would have expected it to fail when I upgraded the template lint dependency itself, not here. Anyway, the config option for Octane was removed in ember-template-lint v4.
Ah, sorry about that!
I'll take a look tonight and see if I can get a working change set out for your review.
Hi @jenweber, I think that the linter issues are coming from ember deprecation-lint
. At a high level, it looks like there are really two separate problems here:
@ember/render-modifiers
deprecation-lint
config setting for the allowed versions of @ember-concurrency
does not include the version that we and ember-styleguide
both want to use.Digging into the first issue a bit, the dependency tree looks like:
deprecation-app
├── @ember/render-modifiers@1.0.2
├─┬ ember-showdown-prism
│ └─┬ ember-prism
│ └── @ember/render-modifiers@1.0.2
└─┬ ember-styleguide
└── @ember/render-modifiers@2.0.5
Interestingly, we do depend on render-modifiers, but don't appear to actually use it from what I can tell, so I submitted #1283 to remove that. For ember-showdown-prism
, I went ahead and updated that in this pull request since it needs to be updated in lockstep with ember-styleguide
. edit; Additionally, ember-showdown-prism
depends on ember-auto-import
v2 or greater, so I've pulled that in too.
For the second issue, since we and ember-styleguide
want to use the same version, I think that we should just be able to remove that allowedVersion
setting in the config/dependency-lint.js
file to resolve the linter error.
I think that once https://github.com/ember-learn/deprecation-app/pull/1283 has been merged, this should lint successfully (or at least it did when I merged it locally).
Please let me know if there's anything else that I can do here! 😄
I updated this branch with main
after merging #1283. The tests are still unhappy, but this time we get a different error output:
this version of ember-auto-import requires the app to have a dependency on webpack 5
I think possibly this can be solved by installing webpack. It looks like they are still on v5.
npm install --save-dev webpack
Ah, darn! I'm not sure why I'm not seeing that locally... I'll try your suggestion and see if that makes the CI happy. Sorry for the inconvenience here.
Thanks for the suggestion, that seems to have done the trick!
Please let me know if there's anything else that we should do here. 😃
At build time, a warning is logged:
As such, let's bump to the newest version of this package. See https://github.com/ember-learn/ember-styleguide/releases for the package's release notes.
This should help along the way to achieving: #1272.